Ok, looks fine,
Please file a separate CR for the icons.
On 15/01/2019 22:58, Pankaj Bansal wrote:
Hello Sergey,
Thanks for the review.
According to the documentation, from gtk 3.10, they have deprecated the stock items
themselves and are advising not to use those. Gtk is advising to use Named Icons and
Labels instead of stock icons. But I think that would be a big change and will be done as
an "Enhancement" in separate bug.
Currently, the gtk-ok, gtk-no, gtk-cancel etc. icons are present in both OEL and Ubuntu and are working fine. Also, gtk3 has not
given any new icon names for these stock icons to use like changing "gtk-dialog-error" to "dialog-error"
etc. Instead are advising to use Labels like use Label "_Cancel" instead of stock icon "gtk-cancel". This all
will have to be done with the "Enhancement" where we will deprecate the Stock icons from gtk 3.10. So I have not made
any changes for those here.
Please let me know if this looks good.
Regards,
Pankaj
-----Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, January 15, 2019 4:37 AM
To: Pankaj Bansal; [email protected]
Subject: Re: <Swing Dev> [13] RFR JDK-8214111: There is no icon in all
JOptionPane target image
Hi, Pankaj.
Based on the links below the next names were deprecated as well:
"gtk-ok", "gtk-cancel", "gtk-dnd" etc.
Should we change them as well?
On 14/01/2019 04:26, Pankaj Bansal wrote:
https://developer.gnome.org/gtk2/stable/gtk2-Stock-Items.html#GTK-STOC
K-DIALOG-ERROR:CAPS
https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOC
K-DIALOG-ERROR:CAPS
--
Best regards, Sergey.
--
Best regards, Sergey.
