Looks fine.
On 19/02/2019 21:17, Prasanta Sadhukhan wrote:
Hi Sergey,
I guess that code was commented out anyway I have removed that line in the
modified webrev
http://cr.openjdk.java.net/~psadhukhan/8219156/webrev.1/
Regards
Prasant
On 20-Feb-19 2:37 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
Looks like in the test you have a code to check a foreground color(attrBackground,
"green_foreground ") but it is unused.
On 19/02/2019 03:23, Prasanta Sadhukhan wrote:
Hi All,
Please review a fix for an issue where it is seen that JTextPane with
RTFEditorKit writes background color for specific word into rtf file but
doesn't read it. So, if yellow background color is set, it will read default
white background.
This is because RTFReader#AttributeTeackingDestination.handleKeyWord() does not handle
"cb" keyword which is Font(character) formatting property for background color
as per http://www.biblioscape.com/rtf15_spec.htm.
Fix is to make it handle "cb" keyword.
Bug: https://bugs.openjdk.java.net/browse/JDK-8219156
webrev: http://cr.openjdk.java.net/~psadhukhan/8219156/webrev.0/
Regards
Prasanta
--
Best regards, Sergey.
