Hi Pankaj,

One question, dont we need to do
1782 fp_gtk_style_context_add_class(context, "background");after 2366 context = get_style(widget_type, "tooltip"); Also,please put noreg-demo in JBS since you are not providing any testcase. Applicable for all gtk3 bugs, I presume.

Regards
Prasanta
On 01-Mar-19 1:25 PM, Pankaj Bansal wrote:

Hi All,

Please review the following fix.


Bug:

https://bugs.openjdk.java.net/browse/JDK-8214253

webrev

http://cr.openjdk.java.net/~pbansal/8214253/webrev00/ <http://cr.openjdk.java.net/%7Epbansal/8214253/webrev00/>

Issue:

From gtk 3.20, gtk has changed the way themes and styles work for many widgets. Due to which, jdk is not able to render some widgets properly including JTooltip. The tooltip background looks transparent, but tooltip background is of same color as background panel.

gtk 3.20 release notes: https://developer.gnome.org/gtk3/stable/ch32s10.html

Fix:

This patch fixes rendering issues in JTooltip by using correct way to define styles.

Testing:

This fix can be verified by running SwingSet2 and using the tooltip. I have verified this on Ubuntu 16.04, 18.04, 18.10 and OEL 7.5.


Regards,
Pankaj Bansal


Reply via email to