Hi Vikrant, although I still don't understand why we are moving exclusiveAccess.dirs to test/jdk/TEST.ROOT, I'm fine w/ the patch.
Cheers, -- Igor > On Mar 5, 2019, at 2:18 AM, Vikrant Agarwal <[email protected]> > wrote: > > Hi Igor, > > Here is the updated webrev: > http://cr.openjdk.java.net/~vagarwal/8219552/webrev.3/ > <http://cr.openjdk.java.net/~vagarwal/8219552/webrev.3/> > > Summary of changes made: > Removed requiredVersion from TEST.properties and README > Removed 'test/jdk/sanity/client/TEST.ROOT.template' as it is not being used. > It is not necessary for all keywords to be under TEST.ROOT file. Right now > test ButtonDemoScreenshotTest.java runs without any errors and if we remove > 'screenshots' keyword from TEST.properties file it throws “Error. Parse > Exception: Invalid key: screenshots”exception. So keeping the TEST.properties > file. > Added "sanity/client" under exclusiveAccess.dirs to test/jdk/TEST.ROOT and > removed exclusiveAccess.dirs from ‘test/jdk/sanity/client/TEST.properties’ > Removed "intermittent" keyword from ButtonDemoScreenshotTest, because > intermittent issue is resolved by JDK-8157338 > Added "screenshots" keyword to EditorPaneDemoTest as this test also has > screenshot tests. > Added GPL legal notice in TEST.properties file > > Best Regards, > Vikrant > > From: Igor Ignatyev > Sent: Friday, February 22, 2019 11:35 PM > To: Vikrant Agarwal <[email protected]> > Cc: [email protected]; Aleksandre Iline > <[email protected]>; Muneer Kolarkunnu <[email protected]> > Subject: Re: <Swing Dev> [13] RFR JDK-8219552:bump jtreg requiredVersion to > b14 in test/jdk/sanity/client/ > > Hi Vikrant. > > could you please explain how 'test/jdk/sanity/client/TEST.ROOT.template' is > used? if it's not used at all, I'd prefer to delete this file for good. > > I also have kinda same question to 'TEST.properties' file. AFAIR jtreg > doesn't extending 'keys' in 'TEST.properties' files, which means all keywords > must be listed in 'TEST.ROOT' file, and using of any other unregistered > keywords leads to 'Error. Parse Exception: Invalid key: ...'. 'screenshots' > isn't registered in test/jdk/TEST.ROOT, having it in > 'test/jdk/sanity/client/TEST.properties' has no effect, so > 'test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java' (the only > test w/ screenshots) can't be executed and will always fail w/ error status. > so I'm wondering if you doing something w/ test/jdk/sanity/client/ before > running these tests. > > Thanks, > -- Igor > > > On Feb 21, 2019, at 9:56 PM, Vikrant Agarwal <[email protected] > <mailto:[email protected]>> wrote: > > Hi All, > Please review this small fix for JDK-8219552 > <https://bugs.openjdk.java.net/browse/JDK-8219552>: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8219552 > <https://bugs.openjdk.java.net/browse/JDK-8219552> > Webrev: http://cr.openjdk.java.net/~vagarwal/8219552/webrev.0/ > <http://cr.openjdk.java.net/~vagarwal/8219552/webrev.0/> > Summary: Removed jtreg requiredVersion field from files in > test/jdk/sanity/client/ as it is redundant because jtreg requiredVersion is > specified in test/jdk/TEST.ROOT which is being updated by JDK-8219417 > <https://bugs.openjdk.java.net/browse/JDK-8219417> > Best Regards, > Vikrant
