I am unable to test this since I don't have access to suitable systems,
but it does look like it should be OK as it reverts the function's behaviour
to what it was before 8214253 except for tooltips.
-phil.
On 3/8/19, 7:20 PM, Pankaj Bansal wrote:
Hi All,
Please review the following fix.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8220349
webrev
http://cr.openjdk.java.net/~pbansal/8220349/webrev00/
<http://cr.openjdk.java.net/%7Epbansal/8220349/webrev00/>
Issue:
The fix done for JDK-8214253 have caused issues in JTree behaviour. If
the JTree node is selected, its background and text color become white
and nothing is readable.
The changes done in gtk3_paint_flat_box for JDK-8214253 have caused
this issue as the changes were made for all the widgets. JDK-8214253
is specific to TOOL_TIP. So JDK-8214253 can be fixed by making changes
only for TOOL_TIP like done in gtk3_get_color_for_state. The
gtk3_paint_flat_box is also called by other widegts like JTree cell
rendering and they have been handled well in transform_detail_string.
So we don't want to copy the same code in get_style.
Fix:
This patch fixes the issue by making the changes done in
gtk3_paint_flat_box specific to TOOL_TIP like were done in
gtk3_get_color_for_state
Testing:
This fix can be verified by running SwingSet2 and using JTree. I have
verified this on Ubuntu 16.04, 18.04, 18.10 and OEL 7.5.
Regards,
Pankaj Bansal
