Friendly reminder. Thanks, Dmitry
> On 27 Jun 2019, at 12:59, Dmitry Markov <[email protected]> wrote: > > Hello, > > Could you review a fix for jdk14, please? > > bug: https://bugs.openjdk.java.net/browse/JDK-8225505 > <https://bugs.openjdk.java.net/browse/JDK-8225505> > webrev: http://cr.openjdk.java.net/~dmarkov/8225505/webrev.00/ > <http://cr.openjdk.java.net/~dmarkov/8225505/webrev.00/> > > Problem description: > When tool tip is set for JMenuItem ToolTipManger registers a special key > listener for this item. The listener is intended for processing tool tip key > bindings, (i.e CTRL + F1) and show or hide tool tip message. However > BasicPopupMenuUI.MenuKeyboardHelper handles all key events for menu elements. > In other words a menu element such as JMenuItem does not handle a key event > directly. As a result the tool tip messages, which is set for JMenuItem, > cannot be shown using CTRL + F1 combination. > > Fix: > BasicPopupMenuUI.MenuKeyboardHelper should detect tool tip key sequence and > forward it to currently highlighted(selected) for further processing. > > Thanks, > Dmitry
