> Please review the following fix for jdk16.
> 
> Issue : There is a  JToggleButton that will post/take down a JPopupMenu when 
> the button is selected. If the button is selected and the menu is not posted 
> the action listener will post the menu. If the button is selected and the 
> menu is displayed the action listener will take the menu down. The use case 
> is:
> 1 - select button
> 2 - menu posted
> 3 - select button
> 4 - menu taken down
> 
> With MetalLookAndFeel the above use case works fine, but with 
> WindowsLookAndFeel the second button selection does not fire the 
> actionPerformed event,  button needs to be selected third time for the menu 
> to be taken down.
> 
> The issue is that the button must be selected twice after the menu is posted 
> to have the actionPerformed event to fire when using the Windows look and 
> feel.
> 
> Fix : MouseGrabber is not removed while uninstalling the listeners in the 
> BasicPopupMenuUI.
> By removing the mouseGrabber in the uninstallListeners() methods fixes this 
> issue.
> 
> Added a test to test the same in all the LookAndFeels

Tejpal Rebari has updated the pull request incrementally with one additional 
commit since the last revision:

  reworked fix, also fixed for nimbus,motif,GTK LAF

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/600/files
  - new: https://git.openjdk.java.net/jdk/pull/600/files/65c08eda..036633b4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=600&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=600&range=01-02

  Stats: 13 lines in 6 files changed: 0 ins; 8 del; 5 mod
  Patch: https://git.openjdk.java.net/jdk/pull/600.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/600/head:pull/600

PR: https://git.openjdk.java.net/jdk/pull/600

Reply via email to