On Fri, 12 Feb 2021 13:09:01 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>>> I guess instead of depending on passed parameter, it will be better to >>> capture the image only on failure. >> >> That's an option. However, I don't think the image adds much value here. > > It might be during failure :-) [which is why it is captured during failure > for many other regression tests] Yeah, sure. Likely, this kind of issue will be reproducible in other environments if it fails. My initial idea during #1759 was to show a frame which would be useful during debugging. I hope it will never fail again. :) Anyway, I'm okay with whatever solution @stanio implements. The easiest one, however, is to use the second parameter to save the image. Sometimes it's useful to have the image captured even when the test does not fail. ------------- PR: https://git.openjdk.java.net/jdk/pull/2515
