On Wed, 17 Feb 2021 13:47:19 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> I guess since you are modifying the test, it's better to convert into main >> based from applet. >> Please remove %W% %E% from @test tag and also @author tag >> Also, JFileChooser.showOpenDialog() can throw HeadlessException, so you need >> to mark the test @headful once you convert to main based. > >> >> >> I guess since you are modifying the test, it's better to convert into main >> based from applet. >> Please remove %W% %E% from @test tag and also @author tag >> Also, JFileChooser.showOpenDialog() can throw HeadlessException, so you need >> to mark the test @headful once you convert to main based. > > @mrserb is against converting manual applet-based tests one-by-one, see [his > comment](https://github.com/openjdk/jdk/pull/2094#discussion_r558717221) in > #2094. Thus, I'd rather leave the test as is. However, I agree `%W% %E%` can > be removed from `@test` tag and `@author` tag can be dropped completely. I would also suggest expanding the wildcard import import javax.swing.*; with imports of specific classes that are used by the test and then sorting the imports. An IDE can do this for you. ------------- PR: https://git.openjdk.java.net/jdk/pull/2587
