On Mon, 22 Feb 2021 15:36:20 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java line 
>> 1908:
>> 
>>> 1906:             if ("focusAccelerator" == propertyName) {
>>> 1907:                 updateFocusAcceleratorBinding(true);
>>> 1908:             } else if ("componentOrientation" == propertyName) {
>> 
>> It is not a part of the fix, but shouldn't we use `equals()` instead of `==` 
>> for String comparison?
>> 
>> Please also update the copyright year.
>
> I dont see the need. Also, it's not mandatory to change the copyright year 
> which will be taken care of by script at end of release.

I suggest changing the copyright year, did you remember then someone run any 
scripts for that?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2673

Reply via email to