On Tue, 2 Mar 2021 13:45:07 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with
>> "Exception: Failed to hide opaque button"
>
> test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 192:
>
>> 190: ImageIO.write(fullScreen, "png", new
>> File("fullScreenInit.png"));
>> 191: throw new Exception("Failed to show non-opaque button");
>> 192: }
>
> Does it make sense to move this block above before `invokeAndWait` to make
> the sequence of actions consistent?
Well, functionally it will not make any difference, we are analyzing the
screenshots and the only thing that matters is at which time screenshot was
taken. The only reason we don't take all screenshots in the beginning and
analyze them later is to save test run time if test runs early. At the end it
is not critical anymore. And as i said this is an existing test so i'm trying
not to change it unless it affects its functionality.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2790
