On Tue, 3 Aug 2021 06:03:21 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> I have looked at >> https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/_nimbusDefaults.html >> where default color for >> EditorPane.background and TextPane.background is NimbusBlueGrey and not >> White what we have now, so I think we are having what is being specified in >> nimbus-default. >> SwingSet2 background color for the demos are same before and after the fix. >> I am not sure about the difference between background and shape but I have >> ran full JCK/JTREG tests and all are fine. I also tried passing Nimbus L&F >> via CI script for JCK/jtreg tests and those are also same before and after >> fix. > > In the linke above the > nimbusBlueGrey #a9b0be (169,176,190) > While the "EditorPane.background and TextPane.background" are: > TextPane.background #d6d9df (214,217,223) > EditorPane.background #d6d9df (214,217,223) > > It is still unclear why setting these values in the XML file prevents the > user to change it later, also it will be good to understand the purpose of > "shape" since it also sets some coordinates values. Yes, I meant the grey background what is being described in EditorPane.background and TextPane.background is what is being shown now, not literally NimbusBlueGrey. Till now we were showing white which is in contrary to this default. I could not find any purpose of shape by looking at skin.laf as it is not being used in Synth source code, so that is why I ran all JCK/jtreg testsuite and found no regression. It is also there from initial days. I leave it for user of Synth/Nimbus L&F or anyone from open community to highlight the need of "shape" ------------- PR: https://git.openjdk.java.net/jdk/pull/4930
