Hi Greg,

Would you mind having a look regarding the CMake configuration for how zlib is handled on Windows? This issue described below is not resolved yet. I tried to make some changes in the CMake configuration some time ago, but did not succeed.

Best regards,
Tobias

-------- Forwarded Message --------
Subject: Re: [sword-devel] Latest SWORD trunk / Build issue on Windows (Root-cause: CMake configuration related to zlib)
Date:   Sun, 14 Mar 2021 01:13:43 -0600
From:   Greg Hellings <greg.helli...@gmail.com>
To:     Tobias Klein <cont...@tklein.info>



So is our solution just to remove the conditional files for when ZLib is not found? Is ZLib now a hard dependency instead of an optional one?

--Greg

On Sat, Mar 13, 2021 at 10:01 AM Tobias Klein <cont...@tklein.info <mailto:cont...@tklein.info>> wrote:

   Hi Greg,

   Not sure whether you saw this ... I need your help on this.

   Have a great weekend!

   Best regards,
   Tobias

   On 2/22/21 8:30 AM, Tobias Klein wrote:

    Hi Greg,

    Would you mind taking a look?
    I checked what needs to be done to remove the zlib references, but
    it was difficult to determine all the places that need to be
    changed. Let me know if I can help.

    Best regards,
    Tobias

    On 2/16/21 11:16 PM, Tobias Klein wrote:
    Dear Troy,

    Is it maybe this reference in /cmake/sources.cmake (line 214)

    SET(sword_zlib_nofound_SOURCES
     src/utilfuns/zlib/adler32.c

    Best regards,
    Tobias

    Am 16. Februar 2021 22:42:51 schrieb "Troy A. Griffitts"
    <scr...@crosswire.org> <mailto:scr...@crosswire.org>:

    Dear Tobias,

    I have just had a look at a pristine checkout of SWORD trunk and
    I have no trace of adler32.c in any CMakeList.txt.  Could this
    be similar to the stray symbols and such you were having with
    your build framework previously, which we stipulated was due to
    no completely cleaning build staging folders?

    If you can find the CMakeList.txt with a line 85 containing a
    reference to adler32.c, please let me know and I will continue
    to investigate.

    Glad the new toUpper code is working for you.

    Troy


    On 2/16/21 4:18 AM, Tobias Klein wrote:
    Hi Zdenko,

    That Windows build (automated via GitHub Actions, also
    considering zlib) has been previously working (Last time when
    1.9.0 was released), so I would rather guess that this is a
    regression in the CMake configuration of SWORD.

    Best regards,
    Tobias

    Am 16. Februar 2021 09:21:01 schrieb ZdPo Ster
    <zdpos...@gmail.com> <mailto:zdpos...@gmail.com>:

    I expect that zlib is installed on Mac by default, while on
    windows cmake configuration does not find a suitable zlib
    installation, so it tries to build it (but source code is
    missing).

    Try to install https://github.com/madler/zlib
    <https://github.com/madler/zlib> with cmake before configuring
    and building the sword.

    Zdenko

    On Mon, 15 Feb 2021 at 18:33, Tobias Klein
    <cont...@tklein.info <mailto:cont...@tklein.info>> wrote:

        Hi,

        I have observed a build issue with the latest SWORD trunk
        on Windows.

        I am getting this message:

        CMake Error at CMakeLists.txt:85 (ADD_LIBRARY):
        112
        
<https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:112>Cannot
        find source file:
        113
        
<https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:113>
        114
        
<https://github.com/ezra-project/sword-build-win32/runs/1904990888?check_suite_focus=true#step:12:114>src/utilfuns/zlib/adler32.c

        When checking the content of /src/utilfuns it appears like
        that folder (zlib) and file (adler32.c) is actually missing.

        I am not getting that error on macOS, so it seems like it
        is a Windows-specific CMake configuration issue?

        Best regards,
        Tobias
        _______________________________________________
        sword-devel mailing list: sword-devel@crosswire.org
        <mailto:sword-devel@crosswire.org>
        http://crosswire.org/mailman/listinfo/sword-devel
        <http://crosswire.org/mailman/listinfo/sword-devel>
        Instructions to unsubscribe/change your settings at above page

    _______________________________________________
    sword-devel mailing list: sword-devel@crosswire.org
    <mailto:sword-devel%40crosswire.org>
    http://crosswire.org/mailman/listinfo/sword-devel
    <http://crosswire.org/mailman/listinfo/sword-devel>
    Instructions to unsubscribe/change your settings at above page


    _______________________________________________
    sword-devel mailing list:sword-devel@crosswire.org  
<mailto:sword-devel@crosswire.org>
    http://crosswire.org/mailman/listinfo/sword-devel  
<http://crosswire.org/mailman/listinfo/sword-devel>
    Instructions to unsubscribe/change your settings at above page
    _______________________________________________
    sword-devel mailing list: sword-devel@crosswire.org
    <mailto:sword-devel%40crosswire.org>
    http://crosswire.org/mailman/listinfo/sword-devel
    <http://crosswire.org/mailman/listinfo/sword-devel>
    Instructions to unsubscribe/change your settings at above page


    _______________________________________________
    sword-devel mailing list:sword-devel@crosswire.org  
<mailto:sword-devel@crosswire.org>
    http://crosswire.org/mailman/listinfo/sword-devel  
<http://crosswire.org/mailman/listinfo/sword-devel>
    Instructions to unsubscribe/change your settings at above page

    _______________________________________________
    sword-devel mailing list:sword-devel@crosswire.org  
<mailto:sword-devel@crosswire.org>
    http://crosswire.org/mailman/listinfo/sword-devel  
<http://crosswire.org/mailman/listinfo/sword-devel>
    Instructions to unsubscribe/change your settings at above page

_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

Reply via email to