Thanks for the explanation Dustin. We understand and accept the risks in running our app against trunk. We decided to make the plunge because of the i18n and validation improvements.
We've reverted to an earlier revision for now. We'll probably make the rewrite changes you suggested shortly because I already see some functionality that we'd like in the revisions immediately following 5814 (default i18n culture for Propel objects in r5815). Cheers, --peterVG > -----Original Message----- > From: Dustin Whittle [mailto:[EMAIL PROTECTED] On > Behalf Of Dustin Whittle > Sent: November 2, 2007 1:55 PM > To: symfony-devs@googlegroups.com; Peter Van Garderen > Subject: Re: [symfony-devs] $request argument in > sfAction::execute method? > > Peter, > > > > > > We are running off of Symfony 1.1 trunk. After updating > today we had all our > > module actions crash because of changeset 5814 which added > the request as an > > argument to the sfAction::execute() method. > > > > While the code committed to the trunk should be stable, it is not > well-tested and not recommend to develop applications from > (as things are > constantly changing). > > > Can someone explain the wider context for this change (i.e. > what is it > > doing/going to do?). > > From what I can see the wider context is such that > dependencies are now > being injected into methods. For a bigger picture see > Fabien's slides from > symfonyCamp about moving towards symfony 2.0. The overall > idea is easily > explained: request -> stuff happens -> response. See slides > for more info.. > > > What should we do to make this backwards/forwards > > compatible? > > I presume this will eventually have an upgrade task.. In the > mean time you > can simply rewrite your methods to executeActionName($request). > > - Dustin > > > > > > We'll roll back to the previous revision in the meanwhile. > > > > Cheers, > > > > --peterVG > > > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to symfony-devs@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
