Hi all,
The discussion on version 2 of the RFC has mainly been on how to name
the arguments. Based on that, I have slightly updated the RFC. As of
version 3, arguments for constructors are unchanged:
function __construct(User $user, $maxPerPage)
{
}
But arguments for action methods have suffixes (Service and Parameter):
function showAction($slug, $mailerService, $maxPerPageParameter)
{
}
This means that all the conflict problems are now gone.
Notice the asymmetry between how we pass things to constructors and
methods (this is a bit of a concern for me).
Also notice that the example compatible with symfony 1 is a bit
different now:
function showAction(Request $requestService)
{
}
And if you ask for both the request and the container:
function showAction(Request $requestService, Container
$containerService)
{
}
If nobody comes with more comments on the RFC, I think the next step can
be a vote to choose which approach to implement (the chosen approach
will of course be discussed a bit more to fine-tune things before and
during implementation - like the suffix names, ...).
I propose the following simple rules for the vote:
* "Regular" subscribers to the mailing-list can vote by replying to
this email with the approach he likes best (1 point per person);
* The members of the core team have 5 points each. The vote for core
team members counts more because they will need to implement and
maintain the chosen solution ;)
Fabien
--
Fabien Potencier
Sensio CEO - symfony lead developer
sensiolabs.com | symfony-project.org | fabien.potencier.org
Tél: +33 1 40 99 80 80
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
To unsubscribe from this group, send email to symfony-devs+unsubscribegooglegroups.com or
reply to this email with the words "REMOVE ME" as the subject.
