On 1/17/11 5:06 AM, Jeremy Mikola wrote:
On moving vendor/ one level up to be parallel with src/, +1 for that.
OpenSky was actually doing this since we started the project in Spring
of 2010. Only recently did we restandarize things based on the current
sandbox and move out vendor directory /into/ src/.
The sandbox actually supports both src/vendor/ and vendor/.
Regarding the comment that "Bundle\Sensio\CasBundle" would change to
"Sensio\Symfony\Bundle\CasBundle"... I think "\Bundle" should be removed
from the latter example. Having "Bundle" in the namespace path at that
point is a bit redundant (the next segment is "Cas*Bundle*"), and it
also breaks the existing best practices of "company, category, name" for
bundles.
This does not break the best practices as category is actually categories.
So, if I follow you, here is what you are suggesting:
Current:
Symfony\Bundle\FrameworkBundle
Symfony\Bundle\DoctrineBundle
Symfony\Component\Finder
Bundle\Sensio\CasBundle
My suggestion:
Symfony\Bundle\FrameworkBundle
Symfony\Bundle\DoctrineBundle
Symfony\Component\Finder
Sensio\Symfony\Bundle\CasBundle
Yours:
Symfony\FrameworkBundle
Symfony\DoctrineBundle
Symfony\Component\Finder? or Symfony\Finder?
Sensio\Symfony\CasBundle
Seems to me that the Bundle/ category is nice to have. One goal is to
also make the naming of code bundles use the same rules as third-party
ones. Core bundles just happens to use Symfony as their vendor.
I don't support renaming src/ to bundles/, as I think "src" is both more
descriptive for general developers of many languages/frameworks. Once a
developer reads about Symfony2, he'll learn the "everything is a bundle"
mantra, and the "src/" name will still make sense IMO. Also, four less
characters in a top-level name will be much appreciated when we're
typing this in our terminals.
Lastly, I suppose I understand why some folks might use vendor/ to store
all of their external libraries (e.g. git submodules, svn exports), but
in my experience with OpenSky, we only threw in stand-alone vendor code
there. Stuff like Symfony2, Doctrine, Zend, swiftmailer, Twig and the
like. Any third-party bundles we used went under src/Bundles, which I
now expect would be src/Company and sit right next to our own bundles in
src/OpenSky.
--
If you want to report a vulnerability issue on symfony, please send it
to security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
