Hi all,

i recognized a small issues with the brand-new doctrine annotation
reader of the 3.0.x branch. So may i ask for your rating:

https://github.com/doctrine/common/blob/3.0.x/lib/Doctrine/Common/Annotations/AnnotationReader.php

The constructor signature lacks of the in the doc-comment promised
argument. This prevents the parser from beeing parametrized in order
to e.g. call setIgnoreNotImportedAnnotations(false).

Even worse: because all members are declared private, there is no way
to extend the class and hot-fix the constructor code.

This leads to non-functional code if one uses "exotic" annotations
like for example "@api" in the symfony context.

Do you think this should be regarded in a future bugfix?

p.s. I like the "new way" of importing annotations by the use keyword
very much, thanks for your hard work on that.

Thank you in advance and best regards
Johannes

-- 
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to