On 5/23/11 5:04 PM, ryan weaver wrote:
Hi guys!
In many of our semantic configurations, we use the "cache_warmer"
config. It's always a string, but effectively used as a Boolean. If you
look in symfony-1.0.xsd, the "cache_warmer" can be "true", "false", or
"full". Currently, most places just look for true/false and
tag/don't-tag a cache warming service based on that value. In the case
of the main "framework" cache_warmer, it looks for the presence/absence
of the word "full" (i.e. setting to true/false is equivalent, "full" is
the only special value).
1. Is there a use case for "cache_warmer" to be *more* than a Boolean?
Are there any arguments against changing "cache_warmer" to be a Boolean?
2. Also, might we change the name to "cache_warmup"? The string
"cache_warmer" tends to be the "subject" that does the cache warming.
However, in the configuration, we're expressing whether or not we'd like
to "warmup the cache". The container parameter is already called
"kernel.cache_warmup".
I've just reworked the cache warmers. I have simplified things a lot:
https://github.com/symfony/symfony/commit/96fc666454195633043b162720940246af76f212
All the cache warmers configuration are now gone as they are not needed
anymore (see the commit message for more information).
That should solve your concerns :)
Fabien
Thanks!
Ryan Weaver
US Office Head & Trainer - KnpLabs - Nashville, TN
http://www.knplabs.com <http://www.knplabs.com/en>
http://www.thatsquality.com
Twitter: @weaverryan
--
If you want to report a vulnerability issue on symfony, please send it
to security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
