Hi everyone,
I'm profiling one application and I'm noticing that there are things
we could improve in the FW:
- UrlGenerator::doGenerate() seems expensive, if you look at the code
you will see that a refactor and some love to the method will help :)
- We should get rid of array_key_exists when possible
- Container::get() method does always $id = strtolower($id); - do we
need to have that check there?, can't we just say the standard is
lowercase and move that responsibility to the developer? - that method
is called thousands of times in my profile
- Twig templates, maybe we should generate templates with computed
translations?, we could gain performance by doing something like that.
I also noticed many many lookups like the following ones in the twig
cache generated ones:
$this->env->getExtension('assets')->getAssetUrl(...)
$this->env->getExtension('translator')->getTranslator()->trans("Go
to home page", array(), "core");
Maybe we should assign those extensions to variables so we avoid
looking for them every time?
What do you think?
Cheers!, and very good overall performance, congratulations :)
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
