It has already been fixed in master.

Fabien

--
Fabien Potencier
Sensio CEO - Symfony lead developer
sensiolabs.com | symfony.com | fabien.potencier.org
Tél: +33 1 40 99 80 80


On 7/3/12 8:21 PM, Lee Henson wrote:
Hi.

I'm attempting to use the MtHamlBundle with my Symfony 2 app, and I have
it correctly rendering my page ok. However, the WebProfiler's
ProfilerController throws an exception because it has an expectation
when creating a TemplateManager because it requires the 'templating'
service to return a TwigEngine:

     protected function getTemplateManager()
     {
         if (null === $this->templateManager) {
             $this->templateManager = new TemplateManager(
                 $this->container->get('profiler'),
                 $this->container->get('templating'),
                 $this->container->get('twig'),
                 $this->container->getParameter('data_collector.templates')
             );
         }

         return $this->templateManager;
     }

When the MtHamlBundle is loaded, container->get('templating') returns a
DelegatingEngine. I have created a branch in which I've changed the
requirement in the TemplateManager so it accepts any EngineInterface. Is
this the right way to approach fixing it?

https://github.com/leemhenson/symfony/commit/a9136531d9d86bd9a0ea8ba8e1c68c22b74de074

Cheers
Lee

--
If you want to report a vulnerability issue on symfony, please send it
to security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en


--
If you want to report a vulnerability issue on symfony, please send it to 
security at symfony-project.com

You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en

Reply via email to