On 30 July 2012 10:27, Christophe COEVOET <[email protected]> wrote: > Le 30/07/2012 11:13, Drak a écrit : > > The other problem you will find is DoctrineBundle relies on >> FrameworkBundle as FrameworkBundle strangely has the annotation services >> from Doctrine\Common. So in the end, if you use DoctrineBundle it's going >> to require FrameworkBundle, which in turn will require everything else so >> your current RFC will have no net gain. It would be great if the >> annotations services were moved into DoctrineBundle, or if necessary a new >> DoctrineCommonBundle since Doctrine\Common is a set of decoupled libraries. >> >> Drak >> >> >> It does not make any sense to move the annotation reader to > DoctrineBundle: it would make FrameworkBundle reqauire it as it uses it > (for teh validation), as well as all other bundles using annotations (they > should all use the same reader to avoid reading the annotation 10 times > which would be a performance issue)
And clearly it makes no sense for someone who wants the annotations but not the frameworkbundle (and thus all of Symfony because it depends on it). I agree annotations make little sense in DoctrineBundle, but equally makes less sense in FrameworkBundle. DoctrineCommonBundle would make a lot more sense since it does not introduce any more dependencies. Even if the bundle system is separated to it's own component, the original author suggests that to have a soley CLI component he doesnt also want KttpKernel. If that CLI requires DoctrineBundle, it's going to require FrameworkBundle, which will then require everything else, including the original HttpKernel. Net change is zero. Drak -- If you want to report a vulnerability issue on symfony, please send it to security at symfony-project.com You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en
