On 6/4/07, andyjeffries <[EMAIL PROTECTED]> wrote:

> I'm happy to supply a patch,

great :)

> but can you give me any hints on how to
> add it neatly (rather than just hacking it in to get it to work)?

 * create a ticket about plugin not supporting multiple databases
 * checkout plugin's latest sources from subersion :
http://svn.symfony-project.com/plugins/sfPropelActAsNestedSetBehaviorPlugin/
 * configure unit test file for your environment (as described in
http://svn.symfony-project.com/plugins/sfPropelActAsNestedSetBehaviorPlugin/test/unit/PropelActAsNestedSetBehaviorTest.php
docblocks)
 * run tests to know what works and what doesnt before you start
modifying the code
 * write unit tests related to multiple database handling
 * make your modifications
 * rerun tests to make sure you did not break anything and that your tests pass
 * update README (especially public API docs)
 * generate patch
 * attach patch to ticket

if you really don't succeed in writing the unit tests, don't bother
and go on with the code ;)
it will just take a bit longer for your patch to go upstream (i will
need time to write the missing unit tests).

don't hesitate to ask me for help off-list.

regards,

tristan

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"symfony users" group.
To post to this group, send email to symfony-users@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/symfony-users?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to