Updates:
        Status: Accepted

Comment #5 on issue 1158 by ondrej.certik: regression: roots of polys
http://code.google.com/p/sympy/issues/detail?id=1158

I think neither problem in this issue is actually fixed:

In [1]: p1 = ((x-2)*(x+3)*(x-4)).expand()

In [2]: p1
Out[2]:
                2    3
24 - 10⋅x - 3⋅x  + x

In [3]: roots(p1,x)
Out[3]: {}

In [4]: roots(p1, x, cubics=True)
Out[4]: {-3: 1, 2: 1, 4: 1}

In [5]: p = x**4 - 6*x**3 - 21*x**2 + 118*x + 216

In [6]: roots(p,x,quartics=True)
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)

/home/ondra/repos/sympy/<ipython console> in <module>()

/home/ondra/repos/sympy/sympy/polys/rootfinding.pyc in roots(f, *symbols,  
**flags)
     256
     257             for i, h in enumerate(poly_sqf(g)):
--> 258                 for zero in roots_trivial(h):
     259                     if zeros.has_key(zero):
     260                         zeros[zero] += i+1

/home/ondra/repos/sympy/sympy/polys/rootfinding.pyc in roots_trivial(g)
     226             elif n == 4:
     227                 if flags.get('quartics', False):
--> 228                     zeros += roots_quartic(g)
     229
     230         return zeros

/home/ondra/repos/sympy/sympy/polys/rootfinding.pyc in roots_quartic(f)
      72     r = c**2 + a**2*d - a*b*c
      73
---> 74     r = cubic(1, p, q, r)
      75
      76     u = r[1] + r[2] - r[0]

NameError: global name 'cubic' is not defined


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to