Comment #16 on issue 339 by fab...@fseoane.net: Series and expand as  
functions
http://code.google.com/p/sympy/issues/detail?id=339

I have some objections:

    - e is not a nice parameter name in series() method for the expression,  
as it can
be confused with the E constant. In my opinion variables consisting an a  
char should
be avoided. (maybe e -> expr)

    - no need to sympify twice x and point, see the code for Basic.series(),  
as it
already does simpify those argument's

    - I don't think putting var in the tests is a good idea, since it  
appends a symbol
to the global namespace, that can conflict with other symbols declared  
later.

    - Last test lacks assert

    - Please consider writing some documentation to put in  
doc/src/modules/series.txt,
even if it's just a link to the docstring.

    - it does not seem to work for values of point other than 0. See issue  
#1334. A
workaround for this might be to do the series expansion for x-point at 0.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to