Comment #22 on issue 1358 by wflynny: (e*f*e*f).subs(e*f,f*e+h) fails if e*f is not commutative http://code.google.com/p/sympy/issues/detail?id=1358
Assuming that those failed utilities\pytest.py tests are acceptable, I have only a couple more comments on this: The tests for the chebyshev polynomials should include a simplify term: def test_chebyshev(): assert chebyshevt(0, x) == 1 assert chebyshevt(1, x) == x assert chebyshevt(2, x) == 2*x**2-1 assert chebyshevt(3, x) == 4*x**3-3*x for n in range(1, 4): for k in range(n): z = chebyshevt_root(n, k) + assert simplify(chebyshevt(n, z)) == 0 for n in range(1, 4): for k in range(n): z = chebyshevu_root(n, k) + assert simplify(chebyshevu(n, z)) == 0 If that change is made, my new mul.py fails only 3 tests that I can see: - test_issue953() - in sympy\integrals\tests\test_integrals - test_heurisch_hacking() - in sympy\integrals\tests\test_risch - test_heurisch_radicals() - in sympy\integrals\tests\test_risch They all fail because they cannot decompose polynomials. I think this has something to do with the division problem I commented on earlier which I still haven't fixed. I've hit somewhat of a wall with it and if someone could check it out and just give some feedback, that'd be awesome. Attachments: mul_patch_6-23.diff 11.8 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to sympy-issues@googlegroups.com To unsubscribe from this group, send email to sympy-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en -~----------~----~----~----~------~----~------~--~---