Updates:
        Labels: -NeedsReview NeedsBetterPatch

Comment #11 on issue 1694 by smichr: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694

I think perhaps a single function should be added (isroot(), maybe?) and  
used for the
4 cases (as I recall) where testing of solutions should be done. That way  
you've got
consistent logic being applied and only one place to maintain. Right now  
you use
simplify and not .nonzero in one place but just a simple zero check in  
another.

I believe you should "remove(0)" not "pop(0)" -- pop(0) means that you are  
removing
whichever items is in position indexed zero whereas you want to remove the  
0. Also
make sure that remove(0) works; you might need remove(S.Zero), the latter  
being a
reference to the sympy object "zero".

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to