Comment #1 on issue 1736 by asmeurer: Refactor pattern matching and substitution http://code.google.com/p/sympy/issues/detail?id=1736
Great! Pattern matching became a major frustration for me this summer when I did my ODE work for GSoC. If you look in ode.py, you will see that I gave up on getting some of the pattern matching to work and just wrote my own special functions. It would be great if matches() could do it so that the code is all centralized in one place. Also, another thing to keep in mind, is that this functions needs to be fast. If you put a print statement in matches_commutative, and run the tests, your terminal screen will fill with stuff. I think maybe there is a match in the core somewhere (something like p1*p2**p3 IIRC). I see that there are more commits than 4 now. Are all meant to be reviewed, or only the first four? If it is not all, you should keep separate review and work branches so we don't have to checkout a non-tagged HEAD to test. Also see issue 1601 and issue 1577 (though we already know your opinion on that one :) ). -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to sympy-iss...@googlegroups.com. To unsubscribe from this group, send email to sympy-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en.
