Comment #3 on issue 1702 by asmeurer: Code Quality (was crlf)
http://code.google.com/p/sympy/issues/detail?id=1702

Maybe if there were a more streamlined way to check the coverage, like we  
have for the docstrings coverage.  I am +1
for coverage day.  Maybe we should do it over the summer like we did for  
docday, because that is when people are out
of classes and we generally have more people working on SymPy (but I'll let  
you organize it :) ).  Also, maybe we
should get full coverage first (90%-95%), and then check that we always  
maintain it.

Also I agree to check for indentation and one-liner conditionals.  I think  
the problem with spelling and grammar is that
most text editors that people use for coding do not check for spelling and  
grammar.  At any rate, this is one thing that
can be fixed retroactively without too much negative impact.  It's  
important that the tests pass with every commit so
that the current master is always functional, and so that you can checkout  
any commit in the git history and it will
work (such as with a bisect).  But for minor spelling errors in a commit,  
if they are missed by the review, it should be
fine if they are fixed before the next release.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--

You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.


Reply via email to