Comment #2 on issue 1843 by asmeurer: Increase coverage of ode.py
http://code.google.com/p/sympy/issues/detail?id=1843
Could you make a patch with all of these changes, to be applied on top of
my branch? That would be easier.
Comments:
Typos: Thanks for the catches. I always remember to spell check my
docstrings, but I don't always do it for
comments. The problem is that XCode doesn't have an option to spell check
only strings/comments, so if I
turn on the red lines, all the whole document turns red, which is quite
annoying.
I didn't know about enumerate. Your patch here is based on code from
master, though I think it is still
relevant.
Why is powsimp necessary?
I don't understand your proposed checkodesol change. Can you give an
example?
That constantsimp change looks good (though I would want to test it).
Maybe we should have a similar block
to actually go ahead and simplify exp(C1 + x).
Yes, a set should be faster for membership testing because it is just a
hash table.
for i in make_list…: Of course, that would be better.
Yes, I am aware of the time that test_ode.py takes. I think maybe some of
the homogeneous_coefficients
tests can be skipped (those are generally the slowest ones). Also,
probably the separable tests could
probably be reduced. The thing that needs to be tested the most there is
separatevars. I guess what I need
to do is run each individual test with -k and tabulate the times, though I
should note that some tests I will not
trim down, such as undetermined_coefficients (which aren't that slow
anyway), because I know from when I
wrote the solver that all the tests are needed to verify its correctness.
Of course, the better solution would be to make the integrator faster, but
who knows how do to that? But
maybe I can learn and work on it for GSoC :)
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
