Comment #6 on issue 1852 by smichr: "expand" fails when non-commutative symbols are involved
http://code.google.com/p/sympy/issues/detail?id=1852

It passes everything in 1766, too...but the issue is also present for a non-Add base:

(x*y)**3 -> x**3*y**3 instead of x*y*x*y*x*y

Also, in checking the coverage I see that the next line is uncovered:

return Add(*[f*multi for f in base.args])

This is dead code (I think) since the out if already restricted this section to a base that is an Add and expanding a non-commutative add is going to lead to an Add.

((2*(x+3*y))**3).expand() doesn't expand fully on the first try in 1766:

((2*x*(a+3))**3).expand()
(6*x + 2*a*x)**3
_.expand()
216*x**3 + 8*a**3*x**3 + 72*a**2*x**3 + 216*a*x**3


I made an 1852 commit with the mul base and add base changes and am happy to rebase this on top of the commit that Raffaele does. Or I could just add his name to the
commit (1852 in branch 1766).


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to