Comment #13 on issue 700 by Toon.Verstraelen: pretty: merge test_pretty.py
& test_pretty_unicode.py
http://code.google.com/p/sympy/issues/detail?id=700
First of all: this is a nice patch carefully put together. Just a few very
minor
comments:
- In def test_pretty_ascii_str() and def test_pretty_unicode_str(), there
are several
possible correct results. Could you add a comment why this is the case. (I
don't see it.)
- On line 363 and 364 replace Pow(3, 1, evaluate=False) by expr.
- There are guidelines for the usage of blank lines in Python code:
http://www.python.org/dev/peps/pep-0008/. (This PEP is a nice guide in
general, but
you can skip to the part 'Blank lines'.) There is a part with five blank
lines in a
test function around line 1595. I would reduce this to at most two. I see
your point
of using lots of blank lines though.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
