Updates:
        Labels: -NeedsReview PassedReview

Comment #41 on issue 1694 by asmeurer: solve has many issues with fractions
http://code.google.com/p/sympy/issues/detail?id=1694

It looks good to me. I like the strategy used for checksol(). My only worry is that it could slow down solve() quite a bit for large expressions with a lot of symbolic coefficients (i.e., all the simplify() functions called there are slow). I haven't actually benchmarked it, though. Maybe there should be an option to turn it off?

This line:

if checksol(b, symbol, sol) is not True: # False or None

should be

if not checksol(b, symbol, sol):

but it's not that important.

I'm not sure what we're doing for pushing right now, so I'll let Ondrej handle that.

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to