Comment #35 on issue 2084 by nicolas.pourcelot: limit(1+1/x, x, 0, dir='-')
fails
http://code.google.com/p/sympy/issues/detail?id=2084
"Nicolas, I fixed the issue of comment 20 in response to someone commenting
on the commit and put in a pull request."
Actually, it was me. ;)
I opened a git account as 'wxgeo' about a week ago.
(And forgot to sign the comment...)
"I like how mine is factored better."
I don't mind, as long as results are correct.
"limit(x**-pi, x, 0) -> zoo"
In fact, you have 2 cases here :
1) limit(x**-pi, x, 0, dir="+") -> +oo
2) limit(x**-pi, x, 0, dir="-") -> zoo (actually, the limit is
oo*E^(-I*pi^2))
There is another thing annoying me in your patch.
For dir='+', you use direct evaluation, relying on 1/0 == oo.
So, fixing issue 2096 would break limit(), since 1/0 would return zoo then.
(For example, limit(1/x, x, dir='+') would return zoo instead of oo).
Concerning tests, I liked your initial extensive test coverage. Dealing
with powers is often an headache, so it's easy to break things... and those
tests are quite fast, since there don't call gruntz().
At least, I would keep the tests concerning negative powers.
I keep on reviewing your pull request...
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
