Updates:
        Cc: Ronan.Lamy Vinzent.Steinberg

Comment #19 on issue 2133 by asmeurer: Merge new polynomials manipulation module
http://code.google.com/p/sympy/issues/detail?id=2133

I bisected the sqrt(2) thing down to this commit, which seems unrelated:

commit caecab6c216b0b29222504dfcaf86b732144eacd
Author: Mateusz Paprocki <matt...@gmail.com>
Date:   Tue Dec 28 15:26:17 2010 +0100

    factor() now uses together() internally (#2054)

The difference is in solve(). In polys12:

In [2]: dsolve(diff(f(x), x, x) + 1/f(x)*(diff(f(x), x))**2 + 1/x*diff(f(x), x), f(x), simplify=False)
Out[2]:
                  2
                 f (x)
C₂ + C₁⋅log(x) + ───── = 0
                   2

In [3]: solve(dsolve(diff(f(x), x, x) + 1/f(x)*(diff(f(x), x))**2 + 1/x*diff(f(x), x), f(x), simplify=False), f(x))
Out[3]:
⎡   ⎽⎽⎽   ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽    ⎽⎽⎽   ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎤
⎣-╲╱ 2 ⋅╲╱ -C₂ - C₁⋅log(x) , ╲╱ 2 ⋅╲╱ -C₂ - C₁⋅log(x) ⎦

in master:

In [2]: dsolve(diff(f(x), x, x) + 1/f(x)*(diff(f(x), x))**2 + 1/x*diff(f(x), x), f(x), simplify=False)
Out[2]:
                  2
                 f (x)
C₂ + C₁⋅log(x) + ───── = 0
                   2

In [3]: solve(dsolve(diff(f(x), x, x) + 1/f(x)*(diff(f(x), x))**2 + 1/x*diff(f(x), x), f(x), simplify=False), f(x))
Out[3]:
⎡   ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽    ⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎽⎤
⎣-╲╱ -2⋅C₂ - 2⋅C₁⋅log(x) , ╲╱ -2⋅C₂ - 2⋅C₁⋅log(x) ⎦

Anyway, this isn't very important. We just need to improve constantsimp(). But it's low priority and I don't consider it blocking on this merge.

Does anyone have any problems with polys12? I am going to do a good test run of all the Pythons/ground types to be sure, but assuming those all pass, I think this is ready to go in. The only things that need to be fixed are the sum and keep_sign issues. I will fix the sum issue in my summation branch after this gets merged in, and keep_sign is issue 2151.

So if someone has an issue, raise it soon. I am going to merge this as soon as I finish running the tests (assuming I find no further issues myself).

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to