Status: Accepted
Owner: ronan.l...@gmail.com
Labels: Type-Defect Priority-High Milestone-Release0.7.0

New issue 2371 by ronan.l...@gmail.com: Completely untested modules in sympy.polys
http://code.google.com/p/sympy/issues/detail?id=2371

The modules densepolys, sparsearith, sparsebasic, sparsepolys and sparsetools have 0% coverage by the test suite, which means that they aren't even imported. They don't have any doctest either.

Quite unsurprisingly, they don't seem to work correctly:

In [1]: from sympy.polys.densepolys import DensePoly

In [2]: DensePoly(x, x)
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)

/media/sda2/Boulot/Projets/sympy-git/<ipython console> in <module>()

/media/sda2/Boulot/Projets/sympy-git/sympy/polys/densepolys.pyc in __init__(self, rep, dom, lev)
     10     def __init__(self, rep, dom, lev=None):
     11         if lev is None:
---> 12             rep, lev = dmp_validate(rep)
     13
     14         self.rep = rep

NameError: global name 'dmp_validate' is not defined

In [3]: from sympy.polys.sparsepolys import SparsePoly

In [4]: SparsePoly(x, x)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/media/sda2/Boulot/Projets/sympy-git/<ipython console> in <module>()

TypeError: __init__() takes at least 4 arguments (3 given)


So they should either be fixed, documented and tested before the release, or be removed entirely (since they aren't used at all, they're probably not that useful).

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to