On Fri, Mar 13, 2009 at 9:53 AM, Fabian Seoane <fab...@fseoane.net> wrote: > > Before of this patch, this calculation returned an AssertionError > (see issue #1051).
The new version is worse, IMO. Instead of just asking whether the argument is negative, it now needs to worry about details about the evalf implementation. Also, this version is less general. The right thing to do is to check arg.is_negative or use a function is_negative(arg). It should be up to is_negative to use assumptions, evalf, or any other method to determine whether arg is negative (or whether to do nothing at all), and the details should be hidden behind the is_negative abstraction. Fredrik --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---