Luke wrote: > So this was my first patch, I hope I did everything correctly. I > added tests for issue 1098 to make sure that > > (x * m/s).integrate((x, 1*s, 5*s)) == integrate(x*m/s,(x, 1*s, 5*s)) > > On my first commit I accidentally left some extra print statements in > the test_units.py, so I created another commit with them removed. Is > the general practice to make two separate commits, or can one edit > things and then add them to an already completed commit?
you can easily squash two commits with git, try: git rebase -i origin or google for "git rebase" > > Also, it seems as though I am unable to change the status of Issue > 1098 on the wiki. Are issues only able to be close by the originator > of the issue? If not, what do I need to be able close an issue? sounds strange ... > > Feedback welcome. > > Thanks, > ~Luke > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---
