On Wed, Jun 10, 2009 at 10:45 AM, Fabian Pedregosa<fab...@fseoane.net> wrote: > > Fabian Pedregosa wrote: >> Ondrej Certik wrote: >>> On Wed, Jun 10, 2009 at 9:20 AM, Fabian Pedregosa<fab...@fseoane.net> wrote: >>>> The following are a series of patches that implement the new assumption >>>> system, which >>>> consists of: >>>> >>>> - preparatory stuff (patches 1-5) >>>> - a logic module (much cleaner than the old one) >>>> - new style-assumptions (very simple objects) >>>> - query module, which substitutes the .is_* syntax >>>> >>>> I tried hard to separate these 3 functionalities as much as possible. >>>> >>>> This is more an initial implementation from whom we can star to work >>>> rather than a >>>> finished product, so in case you have any objections, we can start >>>> discussing. >>>> >>>> Thanks for the review, >>> Could you also push this to some branch to github? I'll play with it. >> >> should be in the usual location: >> >> git pull http://fseoane.net/git/sympy.git assumptions > > git pull http://fseoane.net/git/sympy.git master > > (notice branch is master, not assumptions) should be working now,
Patches are ok, tests pass. Code is ok too, I only had some minor remarks regarding docstrings and doctests. It's important to write nice docstrings, because they show up in our documentation. Those should not serve as tests though, only to guide the user, so that he has an idea what the function does. Ondrej --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---
