On Mon, Jun 29, 2009 at 1:37 PM, Ryan Krauss<ryanli...@gmail.com> wrote:
> I think the branch called
> simplify_minus_and_1495
> on my github repo
> git://github.com/ryanGT/sympy.git
> solves and closes issue 1493 (I think it includes the fix for 1495 as well).
>
> Please let me know if I need to separate the solutions to 1493 and 1495.
>
> I would appreciate review and comments.
very nice patch!
+ if den != 0:
+ return num.could_extract_minus_sign()
+ else:
+ return hash(self) < hash(negative_self)
The last two lines are not necessary, are they? see the following line
in the patch:
# As a last resort, we choose the one with greater hash
return hash(self) < hash(negative_self)
running tests now. If all is ok, I'll push this in.
Ondrej
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patches@googlegroups.com
To unsubscribe from this group, send email to
sympy-patches+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/sympy-patches?hl=en
-~----------~----~----~----~------~----~------~--~---
