On Jul 27, 2009, at 2:02 PM, Alan Bromborsky wrote:
> > Ondrej Certik wrote: >> On Mon, Jul 27, 2009 at 6:25 AM, Alan >> Bromborsky<abro...@verizon.net> wrote: >> >>> Vinzent Steinberg wrote: >>> >>>> +1 for all changes, except for the removed test. In my opinion, it >>>> should be fixed or XFAILed. >>>> I'm sorry that parts of your module are broken and nobody noticed. >>>> >>>> Vinzent >>>> >>>> 2009/7/9 Alan Bromborsky <abro...@verizon.net>: >>>> >>>> >>>>> Updates: >>>>> Cc: abro...@verizon.net >>>>> >>>>> Comment #1 on issue 1517 by ondrej.certik: galgebra.GA docstrings >>>>> http://code.google.com/p/sympy/issues/detail?id=1517 >>>>> >>>>> Two other things of note: >>>>> 1. I recently installed ubuntu 9.04 on my machine and could not >>>>> install >>>>> git-gui (I had to do it from source). >>>>> 2. Under some conditions the recent implementation of the __or__ >>>>> operator, "|" in sympy has broken my implementation of "|" as >>>>> the inner >>>>> product of multivectors. I am trying to find a simple example >>>>> of under >>>>> what conditions this happens. I fixed the problem in internal >>>>> GA.py >>>>> calls by using the function I have __or__ call rather than use the >>>>> overloaded operator. >>>>> >>>>> >>>>> >>>> >>> What was did not work was not part of the GA module, but a scalar >>> algebraic simplification on a scalar expression generated by the GA >>> module (the scalar expression was correct). Something had changed >>> in a >>> recent upgrade of sympy and the simplification method I was using no >>> longer worked. Also this test is too complicated to be in tests, >>> it >>> should only be in examples anyway. >>> >>> I will send a follow up email about the "|" operator (breakfast >>> calls). >>> >> >> Many thanks for working on this. Let me know if there is something >> ready to go in. >> >> Ondrej >> >>> >> >> > I think the existing patch referred to is ready to go in. > > Question with regard to "|". Was the "|" recently implemented for > sympy > types? If so what does it do for general symbols and for intergers? It looks like it returns an instance of an Or class: In [1]: S(1)|S(2) Out[1]: Or(1, 2) In [2]: x|y Out[2]: Or(x, y) Aaron Meurer --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---
