On Wed, Mar 17, 2010 at 9:35 AM, Ondrej Certik <ond...@certik.cz> wrote: > On Wed, Mar 17, 2010 at 6:11 AM, Priit Laes <pl...@plaes.org> wrote: >> Hey, >> >> A while ago (last year sometime) I sent a review request about my >> pyflakes branch to the list, but I dont really recall the outcome but >> anyway - it wasn't included... >> >> So here's the proposal again: >> >> I have introduced an 'audit' target that checks sourcecode for various >> defects using Pyflakes tool when calling `setup.py audit`: >> * checks for names that are used but not defined (unused imports) >> * checks for names used before they are defined (missing imports) >> * checks for names which are redefined without having been used >> (unused variables) >> >> IMHO, this is a good to have tool to keep sympy's code from bitrotting >> (there are some code paths that have been broken for a while...). >> >> The change itself to setup.py is quite minor one and when you don't have >> pyflakes installed things still work as normal. You only get an error >> saying you need to install pyflakes when invoking `setup.py audit` >> >> Branch is located at http://github.com/plaes/sympy/commits/pyflakes > > This is very useful, thanks for this. I am running tests now.
Looks good, it's in. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
