Ondrej Certik wrote:
On Wed, Mar 24, 2010 at 4:22 PM, Aaron S. Meurer <asmeu...@gmail.com> wrote:
I am testing your branch now.  I also left some comments on your github.

Does the test_sage patch require sage to test?  If it does, I won't be able to 
review that one, as I don't have sage installed.

It does. Seems like noone was able to test this, but it works for me,
so if you are ok as long as sympy is involved, I'll just push it in.

Ondrej


I just wonder if we should mark the failing tests in test_complex and test_functions as xfail until there is a sage version (widely adopted) that fixes the corresponding bugs? I understand that the bugs are not due to sympy, but still. If someone just runs the sympy tests and happens to have sage installed, he/she will get two failing tests.

cheers,

Toon

--
You received this message because you are subscribed to the Google Groups 
"sympy-patches" group.
To post to this group, send email to sympy-patc...@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-patches+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-patches?hl=en.

Reply via email to