On Sat, Mar 27, 2010 at 12:16 AM, Priit Laes <plaes...@gmail.com> wrote: > Ühel kenal päeval, L, 2010-03-27 kell 07:41, kirjutas Toon Verstraelen: >> Hello, >> >> Could someone please review the patches of issue1356? >> http://code.google.com/p/sympy/issues/detail?id=1356 > > IMHO, it would be more pythonic if it returns ValueError instead of > TypeError when it encounters invalid kwarg. > > ValueError: Raised when a built-in operation or function receives an > argument that has the right type but an inappropriate value... > > TypeError: Raised when an operation or function is applied to an object > of inappropriate type... > > > And while you are at it, please wrap the lines in evalf docs ;)
Otherwise I am +1 to both patches too. Thanks for fixing the printing methods, that really helps. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.