2010/4/19 Addison Cugini <ajcug...@gmail.com>: > Per the issue here: > > http://groups.google.com/group/sympy/browse_thread/thread/59e5dfb987963204/eca6fd634?pli=1 > > I have created methods which allows 'action verbs' to be called both as > global functions and as methods. Any suggestions you have would be > appreciated!
Thanks, looks good, here a few remarks. Wouldn't it make sense to create some tests for a consistent user interface? What about diff(), conjugate() and coeff()? Shouldn't they also be moved to the action verbs section? I think you missed some functions, for example refine() and cancel(), please double-check your patch against the functions mentioned in the cited thread: """ * take the global functions: simplify nsimplify *simp refine cancel invert expand_* apart collect separate together factor and add them as simple (3 lines) methods of Basic, together with automatically transferring the docs. """ Maybe the docs should be automatically transfered? This can be done with ease using the __doc__ attribute. I'm not sure whether nsimplify() should be added to Expr(). See for example: In [1]: nsimplify(1./7) Out[1]: 1/7 In [2]: nsimplify(1./7*x) Out[2]: 0.142857142857143⋅x But this is not an issue of your patch. Vinzent -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
