On Mon, May 10, 2010 at 4:56 AM, Vinzent Steinberg <vinzent.steinb...@googlemail.com> wrote: > 2010/5/10 smichr <smi...@gmail.com> >> >> Only the commits before 1766 are really ready for pushing. I am still >> pulling apart 1766. > > As I already said, it would be much easier if you could create another > branch for review (1766-for-review) which contains only "stable" changes. > This would help to get it in faster.
Yes. I tried to test your branch (without the first commit) and this is what I got: ________________________________ xpassed tests _________________________________ sympy/solvers/tests/test_ode.py:'XPASS: test_1st_homogeneous_coeff_ode2_eq3sol' sympy/solvers/tests/test_ode.py:'XPASS: test_nth_linear_constant_coeff_variation_of_parameters_simplify_False' sympy/solvers/tests/test_ode.py:'XPASS: test_1st_homogeneous_coeff_ode4_explicit' ________________________________________________________________________________ __________ sympy/solvers/tests/test_solvers.py:test_solve_polynomial1 __________ File "/home/ondrej/repos/sympy/sympy/solvers/tests/test_solvers.py", line 144, in test_solve_polynomial1 -x**Rational(1,3)*(2 - 2*I*sqrt(3))/4, AssertionError ________________________________________________________________________________ ______________ sympy/solvers/tests/test_solvers.py:test_tsolve_1 _______________ File "/home/ondrej/repos/sympy/sympy/solvers/tests/test_solvers.py", line 266, in test_tsolve_1 [log(y/2 + sqrt(-4 + y**2)/2), log(y/2 - sqrt(-4 + y**2)/2)]) AssertionError ________________________________________________________________________________ _______ sympy/utilities/tests/test_code_quality.py:test_implicit_imports _______ File "/home/ondrej/repos/sympy/sympy/utilities/tests/test_code_quality.py", line 121, in test_implicit_imports check_directory_tree(SYMPY_PATH, test, exclude) File "/home/ondrej/repos/sympy/sympy/utilities/tests/test_code_quality.py", line 58, in check_directory_tree file_check(fname) File "/home/ondrej/repos/sympy/sympy/utilities/tests/test_code_quality.py", line 110, in test assert False, message_implicit % (fname, idx+1) AssertionError: File contains an implicit import: /home/ondrej/repos/sympy/sympy/utilities/iterables.py, line 250. tests finished: 2071 passed, 3 failed, 5 skipped, 42 expected to fail, 3 expected to fail but passed, in 182.28 seconds DO *NOT* COMMIT! Do all tests (including the code quality) work for you? If so, we need to improve this. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.