Thanks Andy, I think I found a simpler expression in ccode.py in my codegen_C branch. If that implementation passes tests and review, I'll create a patch for fcode.py as well and put it in the codegen_C branch later.
Øyvind On 14 Jul, 23:23, Ondrej Certik <ond...@certik.cz> wrote: > Thanks! > > On Wed, Jul 14, 2010 at 1:20 PM, Andy Ray Terrel <andy.ter...@gmail.com> > wrote: > > > I went ahead and pushed this in since the tests were broken. > > > -- Andy > > > On Wed, Jul 14, 2010 at 2:49 PM, Andy Ray Terrel <andy.ter...@gmail.com> > > wrote: > >> Okay looks like there was a incompatibility with the str.startswith in > >> python2.4 to 2.5. (2.4 doesn't accept tuple arguments). > > >> I've attached a patch. > > >> -- Andy > > >> On Sat, Jul 10, 2010 at 3:40 PM, Ondrej Certik <ond...@certik.cz> wrote: > >>> It's in, thanks! > > >>> On Sat, Jul 10, 2010 at 9:56 AM, Øyvind Jensen <jensen.oyv...@gmail.com> > >>> wrote: > >>>> Here is a patch. > > >>>> Ø > > >>>> lø., 10.07.2010 kl. 05.49 -0700, skrev Øyvind Jensen: > >>>>> Thanks, I'll fix it very soon. > > >>>>> Øyvind > > >>>>> On 9 Jul, 23:51, certik1 <cert...@llnl.gov> wrote: > >>>>> > Hi, > > >>>>> > the new patches about codegen are awesome, as well as Tuple and so on. > >>>>> > Great job! > > >>>>> > Ondrej > > >>>>> > P.S. > >>>>> > I tried to compile on my rhel5 box and got some easy to fix things for > >>>>> > python2.4. > > >>>>> > cert...@hvis6:~/repos/sympy(master)$ time ./setup.py test > >>>>> > Traceback (most recent call last): > >>>>> > File "./setup.py", line 34, in ? > >>>>> > import sympy > >>>>> > File "/home/certik1/repos/sympy/sympy/__init__.py", line 25, in ? > >>>>> > from series import * > >>>>> > File "/home/certik1/repos/sympy/sympy/series/__init__.py", line 4, > >>>>> > in ? > >>>>> > from limits import limit, Limit > >>>>> > File "/home/certik1/repos/sympy/sympy/series/limits.py", line 2, > >>>>> > in ? > >>>>> > from gruntz import gruntz > >>>>> > File "/home/certik1/repos/sympy/sympy/series/gruntz.py", line 5, > >>>>> > in ? > >>>>> > from sympy.simplify import powsimp > >>>>> > File "/home/certik1/repos/sympy/sympy/simplify/__init__.py", line > >>>>> > 11, > >>>>> > in ? > >>>>> > from rewrite import apart > >>>>> > File "/home/certik1/repos/sympy/sympy/simplify/rewrite.py", line > >>>>> > 7, in ? > >>>>> > �...@threaded() > >>>>> > File "/home/certik1/repos/sympy/sympy/utilities/decorator.py", line > >>>>> > 33, in threaded > >>>>> > from sympy.matrices import Matrix > >>>>> > File "/home/certik1/repos/sympy/sympy/matrices/__init__.py", line > >>>>> > 5, in ? > >>>>> > from matrices import Matrix, SMatrix, zero, zeronm, zeros, one, > >>>>> > ones, eye, \ > >>>>> > File "/home/certik1/repos/sympy/sympy/matrices/matrices.py", line > >>>>> > 9, in ? > >>>>> > from sympy.printing import sstr > >>>>> > File "/home/certik1/repos/sympy/sympy/printing/__init__.py", line > >>>>> > 8, in ? > >>>>> > from fcode import fcode, print_fcode > >>>>> > File "/home/certik1/repos/sympy/sympy/printing/fcode.py", line 28, > >>>>> > in ? > >>>>> > from sympy.tensor import Idx > >>>>> > File "/home/certik1/repos/sympy/sympy/tensor/__init__.py", line 4, > >>>>> > in ? > >>>>> > from indexed import Indexed, Idx, IndexedElement > >>>>> > File "/home/certik1/repos/sympy/sympy/tensor/indexed.py", line 147 > >>>>> > args = tuple([ a if isinstance(a, Idx) else Idx(a) for a in args > >>>>> > ]) > >>>>> > ^ > >>>>> > SyntaxError: invalid syntax > > >>>>> > real 0m3.863s > >>>>> > user 0m2.971s > >>>>> > sys 0m0.205s > > >>>> -- > >>>> You received this message because you are subscribed to the Google > >>>> Groups "sympy-patches" group. > >>>> To post to this group, send email to sympy-patc...@googlegroups.com. > >>>> To unsubscribe from this group, send email to > >>>> sympy-patches+unsubscr...@googlegroups.com. > >>>> For more options, visit this group > >>>> athttp://groups.google.com/group/sympy-patches?hl=en. > > >>> -- > >>> You received this message because you are subscribed to the Google Groups > >>> "sympy-patches" group. > >>> To post to this group, send email to sympy-patc...@googlegroups.com. > >>> To unsubscribe from this group, send email to > >>> sympy-patches+unsubscr...@googlegroups.com. > >>> For more options, visit this group > >>> athttp://groups.google.com/group/sympy-patches?hl=en. > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy-patches" group. > > To post to this group, send email to sympy-patc...@googlegroups.com. > > To unsubscribe from this group, send email to > > sympy-patches+unsubscr...@googlegroups.com. > > For more options, visit this group > > athttp://groups.google.com/group/sympy-patches?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
