On Wed, Aug 18, 2010 at 2:22 PM, Ondrej Certik <ond...@certik.cz> wrote: > Hi Brian, Matt and Addison, > > I think the discussion wandered a bit from the review. > > 1) Git history: > > Do you want to keep your history? Does the history bring any value to > sympy? From what I understood, many times it doesn't import, or tests > don't pass. So it seems to me there isn't really any value in keeping > the history, is there? > > Depending on your answer, either: > > * create a set of two or three simple patches, that add the new > functionality, use "git diff" and other things to see what was > changed, or just this link: > > http://github.com/mattcurry/sympy/compare/sympy:master...mattcurry:hilbert2 > > as you can see, the real changes are really really simple (just adding > things and mostly just adding new files).
I forgot to finish this --- or if you feel that the history really brings a value to sympy, keep it as it is. (Also think about the question whether this history wouldn't make debugging sympy using git blame a nightmare.) Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
