Ah, so you are a GSoC student. I wasn't sure if you were. In that case, it would be better if you made your patch into a pull request in GitHub.
If you need git help, ask on IRC (#sympy on freenode). Aaron Meurer On Mar 28, 2011, at 11:12 PM, Jack McCaffery wrote: > Thanks. I just thought I'd let you know that I've uploaded a GSoC proposal to > the wiki and this is the patch I'm trying to submit for acceptance. It's not > much so I thought it might be easy to put through. Any input you have on my > application would be greatly appreciated if you have a few minutes to look at > it > (https://github.com/sympy/sympy/wiki/GSOC-2011,-Jack-McCaffery,-Improved-Series). > > Thanks, > Jack McCaffery > > On Mon, Mar 28, 2011 at 4:47 PM, Aaron S. Meurer <asmeu...@gmail.com> wrote: > I don't have time to review this now, but have added a link to it on an issue > (http://code.google.com/p/sympy/issues/detail?id=2243) so it doesn't get > forgotten. > > Aaron Meurer > > On Mar 27, 2011, at 9:13 PM, Jack wrote: > > > --- > > .../elementary/tests/test_trigonometric.py | 8 +++++++- > > sympy/functions/elementary/trigonometric.py | 16 ++++++++++++---- > > 2 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/sympy/functions/elementary/tests/test_trigonometric.py > > b/sympy/functions/elementary/tests/test_trigonometric.py > > index 37b05c0..ade2aca 100644 > > --- a/sympy/functions/elementary/tests/test_trigonometric.py > > +++ b/sympy/functions/elementary/tests/test_trigonometric.py > > @@ -266,9 +266,15 @@ def test_asin(): > > assert asin(-oo) == I*oo > > > > assert asin(0) == 0 > > - assert asin(Rational(1,2)) == pi/6 > > assert asin(1) == pi/2 > > assert asin(sqrt(3)/2) == pi/3 > > + assert asin(sqrt(2)/2) == pi/4 > > + assert asin(sqrt((5-sqrt(5))/8)) == pi/5 > > + assert asin(Rational(1,2)) == pi/6 > > + assert asin((sqrt(2-sqrt(2)))/2) == pi/8 > > + assert asin((sqrt(5)-1)/4) == pi/10 > > + assert asin((sqrt(3)-1)/sqrt(2**3)) == pi/12 > > + > > > > assert asin(x).diff(x) == 1/sqrt(1-x**2) > > > > diff --git a/sympy/functions/elementary/trigonometric.py > > b/sympy/functions/elementary/trigonometric.py > > index 9b39016..5c4c1b9 100644 > > --- a/sympy/functions/elementary/trigonometric.py > > +++ b/sympy/functions/elementary/trigonometric.py > > @@ -801,14 +801,22 @@ def eval(cls, arg): > > > > if arg.is_number: > > cst_table = { > > - S.Half : 6, > > - -S.Half : -6, > > + sqrt(3)/2 : 3, > > + -sqrt(3)/2 : -3, > > sqrt(2)/2 : 4, > > -sqrt(2)/2 : -4, > > 1/sqrt(2) : 4, > > -1/sqrt(2) : -4, > > - sqrt(3)/2 : 3, > > - -sqrt(3)/2 : -3, > > + sqrt((5-sqrt(5))/8) : 5, > > + -sqrt((5-sqrt(5))/8) : -5, > > + S.Half : 6, > > + -S.Half : -6, > > + sqrt(2-sqrt(2))/2 : 8, > > + -sqrt(2-sqrt(2))/2 : -8, > > + (sqrt(5)-1)/4 : 10, > > + (1-sqrt(5))/4 : -10, > > + (sqrt(3)-1)/sqrt(2**3) : 12, > > + (1-sqrt(3))/sqrt(2**3) : -12, > > } > > > > if arg in cst_table: > > -- > > 1.7.0.4 > > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy-patches" group. > > To post to this group, send email to sympy-patches@googlegroups.com. > > To unsubscribe from this group, send email to > > sympy-patches+unsubscr...@googlegroups.com. > > For more options, visit this group at > > http://groups.google.com/group/sympy-patches?hl=en. > > > > > > > -- > Jack McCaffery > Graduate Student > ICS, University of Louisiana -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
