This pull request refactors SymPy-Bot a little bit. Two chief things were done here (unfortunately it would have been too much work to split them into separate commits):
1. SymPy-Bot now avoids doing redundant things more than once. In particular, for each pull request, the merge is attempted only once, and use2to3 is run only once. Note that py3k-sympy is not cleared between pull requests either, which might potentially create false positive test failures, at least until SymPy issue 3344 is fixed. Also, the branch that is tested is now called test_N, where N is the number of the pull request (like test_123). The branch is not deleted when the tests are done, so if you want, you can checkout the temporary directory and test things. 2. The review summaries have been greatly condensed. Redundant information (i.e., branch hashes) is shown only once at the top, in a clearer English format that now gives the branch names and was inspired by Travis-Bot. Default information, such as the test command, is only shown if it differs from the default. Finally, all url links are now placed inline with the text. The result is a comment summary that I believe not only takes up significantly less space on the pull request page, but is also easier to read. Finally, as one additional note, SymPy-Bot now officially only runs in Python 2.7. This was so that I could use Python 2.7 idioms like set literals and dictionary comprehensions that make the code easier to read (and Python 2.6 support was dubious anyway). Please, please, **please** test this before merging it. As I noted, it refactors quite a bit of the core logic. I've tried to test all possible code paths, but I'm sure I've missed something. You can merge this Pull Request by running: git pull https://github.com/asmeurer/sympy-bot summary Or you can view, comment on it, or merge it online at: https://github.com/sympy/sympy-bot/pull/123 -- Commit Summary -- * Don't ask for GitHub password with --no-comment * Refactor SymPy-Bot * Use a reference-style link for the SymPy Bot GitHub page -- File Changes -- M sympy-bot (178) M utils/cmd.py (4) M utils/testrunner.py (70) -- Patch Links -- https://github.com/sympy/sympy-bot/pull/123.patch https://github.com/sympy/sympy-bot/pull/123.diff --- Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy-bot/pull/123 -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
