On Mon, Dec 10, 2007 at 01:30:57PM +0100, Ondrej Certik wrote:
>
> Hi,
>
> when reviewing patches, sometimes I want to download them and test
> them (I download the attachement),
> but first I just want to look at the code, without testing it - so
> I'd prefer if mercurial sent both inline and attachement patch.
>
> It shouldn't be hard to patch Mercurial to do that for us and then
> have the patch accepted. What do you think about it?
'hg email -a' uses inline attachment, so it is strange patch content is
not displayed. Maybe your email client can be configured to show inline
attachemnts as text by default?
Another possibility: the reason we started to use attachments is that
there are files in SymPy with dos line endings, and when a patch goes to
sympy-patches, googlegroups seem to convert line endings to something
different, and futher 'hg import' fails.
So, maybe we should fix line endings along SymPy and just use plain
text?
Nevertheless, said all that, yes, I think it is fairly easy to modify
'hg email' to send both plain text and attachment.
But the, my setup will probably break: I use mutt <pipe-entry> to pipe
a message to 'hg import', and it will try to import the same patch
twice? Just a thouhgt.
P.S. and also when replying to a message with inline-attached patch,
mutt quotes patch content, so it is very convenient.
--
Всего хорошего, Кирилл.
http://landau.phys.spbu.ru/~kirr/aiv/
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to sympy@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sympy?hl=en
-~----------~----~----~----~------~----~------~--~---
